Skip to content

fix: confirm cost before enabling paid mfa addons#4076

Merged
sweatybridge merged 1 commit intodevelopfrom
confirm-cost
Sep 9, 2025
Merged

fix: confirm cost before enabling paid mfa addons#4076
sweatybridge merged 1 commit intodevelopfrom
confirm-cost

Conversation

@sweatybridge
Copy link
Copy Markdown
Contributor

@sweatybridge sweatybridge commented Aug 25, 2025 •
edited
Loading

What kind of change does this PR introduce?

Bug fix

What is the new behavior?

Avoids bill shock when user accidentally enables paid addons from config push.

Additional context

...
Enabling Advanced MFA - Phone will cost you $75/month, then $10/month. Keep it enabled? [Y/n] n
Enabling Advanced MFA - WebAuthn will cost you $75/month, then $10/month. Keep it enabled? [Y/n] n
Updating Auth service with config: diff remote[auth] local[auth]
--- remote[auth]
+++ local[auth]

@sweatybridge sweatybridge requested a review from a team as a code owner August 25, 2025 10:26
avallete
avallete approved these changes Aug 25, 2025
View reviewed changes
Copy link
Copy Markdown
Member

@avallete avallete left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks good.

FMI how does it work for branches ? Enabling those for branches does also incurs extra cost on top of the project ? Is it included ?

I'm wondering if a user might mistakingly activate the options on every branches just because it use a single config.toml between branching/prod 🤔

@sweatybridge
Copy link
Copy Markdown
Contributor Author

sweatybridge commented Sep 9, 2025

FMI how does it work for branches ? Enabling those for branches does also incurs extra cost on top of the project ? Is it included ?

Yup it will incur extra costs if enabled on branches. Probably would recommend disabling in base config and enable only in remotes block.

@sweatybridge sweatybridge merged commit d0c23a6 into develop Sep 9, 2025
29 checks passed
@sweatybridge sweatybridge deleted the confirm-cost branch September 9, 2025 08:31
@github-actions github-actions Bot mentioned this pull request Sep 16, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@avallete avallete avallete approved these changes

+1 more reviewer

@Izzaddin97 Izzaddin97 Izzaddin97 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@sweatybridge @avallete @Izzaddin97